chore: npm audit fix and ESLint 9 migration #86
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return () => player?.dispose(); | ||
| }, [src]); | ||
| }, [autoplay, controls, fluid, onError, options, player, src]); |
There was a problem hiding this comment.
The useEffect now depends on onError and returns a disposer, so any parent rerender that recreates the handler (e.g., onError={() => setPlayerError(true)} in MediaContentItem) triggers the cleanup, disposes the player, and then re-enters the effect with the stale player reference still truthy. Because no new player is created, the subsequent player.src call runs on a disposed instance, causing playback to stop or throw as soon as the parent component updates state (selecting a carousel item, handling errors, etc.).
Useful? React with 👍 / 👎.
Summary
Testing
Vercel Preview Validation Plan (E2E Click-Around)